[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

errno handling for math library functions is a mess.  Currently, we don't model it properly; we just mark the calls "readnone" and hope for the best.  If you don't want to fix that, just check for readnone for now.

I don't think we want to be querying function attributes or options here; afn plus enabling MASS should be enough.  The function attributes are the old mechanism; we just haven't completely migrated some parts of SelectionDAG yet.



================
Comment at: llvm/include/llvm/Analysis/ScalarFuncs.def:19
+TLI_DEFINE_SCALAR_MASS_FUNC("acosf", "__xl_acosf")
+TLI_DEFINE_SCALAR_MASS_FUNC("__acosf_finite", "__xl_acosf")
+TLI_DEFINE_SCALAR_MASS_FUNC("acos", "__xl_acos")
----------------
Do "__acosf_finite" etc. actually exist on AIX?  I thought they only existed on glibc, and the glibc functions are all deprecated.

I think I'd prefer to track this information in TargetLibraryInfo, like we do for the vector functions, so we can more easily generalize this mechanism in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101759/new/

https://reviews.llvm.org/D101759