[PATCH] D108880: [WebAssembly] Support opaque pointers in FixFunctionBitcasts

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

@dschuff, IIRC, we were talking about what opaque pointers would mean for function pointer casts just the other day. Well here's the answer!



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp:84-86
-        // Only add constant bitcasts to the list once; they get RAUW'd
-        auto C = ConstantBCs.insert(cast<Constant>(U.get()));
-        if (!C.second)
----------------
Why can this logic be removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108880/new/

https://reviews.llvm.org/D108880