[PATCH] D102590: [YAMLParser] Add multi-line literal folding support

[Hassan ElDesouky via Phabricator via llvm-commits]

HassanElDesouky updated this revision to Diff 369295.
HassanElDesouky added a comment.

@scott.linder Thank you so much for the review!

1. I made the changes you pointed out regarding defining a new `scanBlockScalarIndicators` method.
2. I think the idea of `enum BlockStyle` and `enum BlockChomping` is really good. I will definitely implement it but maybe in another PR/diff. -- if that's okay :)
3. I'm afraid that your suggested code in regarding simplifying the logic behind folding is not correct. It doesn't work with folded scalars that has strip/clip. However, I tried my best to simplify the logic. If you have any other ideas let me know!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102590/new/

https://reviews.llvm.org/D102590

Files:
  llvm/include/llvm/Support/YAMLParser.h
  llvm/lib/Support/YAMLParser.cpp
  llvm/test/YAMLParser/spec-09-24.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102590.369295.patch
Type: text/x-patch
Size: 5767 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210829/e0fab5f4/attachment.bin>