[PATCH] D108689: [Linker] Support weak symbols in nodeduplicate COMDAT group

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D108689#2970982 <https://reviews.llvm.org/D108689#2970982>, @MaskRay wrote:

> In D108689#2970961 <https://reviews.llvm.org/D108689#2970961>, @phosek wrote:
>
>> In D108689#2970956 <https://reviews.llvm.org/D108689#2970956>, @MaskRay wrote:
>>
>>> More complete (though still partial) fix: D108879 <https://reviews.llvm.org/D108879>
>>
>> Do you prefer landing your change instead and abandoning this one?
>
> Landing just D108879 <https://reviews.llvm.org/D108879> if no rush for release/13.x:) (which I assume yes because the issue is from a proprietary group which uses rolling updates instead of releases).

I think we need to cherry pick this into 13.x. I can land this one and prepare a cherry-pick for 13.x, and we can then land D108879 <https://reviews.llvm.org/D108879> on top as a more complete solution, is that OK with you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108689/new/

https://reviews.llvm.org/D108689