[PATCH] D108848: [LoopDeletion] Separate logic in breakBackedgeIfNotTaken using symboic max trip count [nfc]

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 28 02:02:20 PDT 2021


nikic added a comment.

This looks reasonable to me, but doesn't seem to be NFC in practice. Your previous change in D108833 <https://reviews.llvm.org/D108833> resulted in a minor code size decrease in CMakeFiles/7zip-benchmark.dir/CPP/7zip/UI/Common/ArchiveCommandLine.cpp.o and CMakeFiles/7zip-benchmark.dir/CPP/7zip/UI/Console/Main.cpp.o at `O3`, and it looks like this change restores the previous size. I strongly suspect that this is just another SCEV invalidation artifact though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108848/new/

https://reviews.llvm.org/D108848



More information about the llvm-commits mailing list