[PATCH] D91512: [AArch64][Isel] Avoid implicit zext for SIGN_EXTEND_INREG (TRUNCATE)

guopeilin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 27 19:23:02 PDT 2021


guopeilin added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:460
+  // For some cases, isBitfieldExtractOpFromSExtInReg() will try to use
+  // SBFMXri + COPY to implement sign_extend_inreg(truncate) during ISel,
+  // However COPY is likely to be erased after register coalescing, So if
----------------
craig.topper wrote:
> Should COPY here be EXTRACT_SUBREG? I think that’s what it is when isel creates it.
Thanks for reviewing, the comment is now modified. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91512/new/

https://reviews.llvm.org/D91512



More information about the llvm-commits mailing list