[PATCH] D108602: [RISCV] Initial support .insn directive for the assembler.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 27 16:32:20 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:1397
+                                          AnyReg:$rs1),
+                             ".insn i $opcode, $funct3, $rs2, ${imm12}(${rs1})">;
+}
----------------
This should have been .insn s


================
Comment at: llvm/test/MC/RISCV/insn.s:44
+
+# CHECK-ASM: .insn i 35, 0, a0, 4(a1)
+# CHECK-ASM: encoding: [0x23,0x82,0xa5,0x00]
----------------
This should be .insn s


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108602/new/

https://reviews.llvm.org/D108602



More information about the llvm-commits mailing list