[PATCH] D108772: [LSR] Make sure that Factor fits into Base type

[Danila Malyutin via Phabricator via llvm-commits]

danilaml updated this revision to Diff 369192.
danilaml added a comment.

Add missing REQUIRES: asserts


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108772/new/

https://reviews.llvm.org/D108772

Files:
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
  llvm/test/Transforms/LoopStrengthReduce/pr42770.ll


Index: llvm/test/Transforms/LoopStrengthReduce/pr42770.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/LoopStrengthReduce/pr42770.ll
@@ -0,0 +1,33 @@
+; Check that it doesn't crash
+; REQUIRES: asserts
+; RUN: opt < %s -loop-reduce -S
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128-ni:1"
+
+define void @foo() {
+bb:
+  br label %bb4
+
+bb1:                                              ; preds = %bb13
+  %tmp = shl i64 %tmp14, 32
+  %tmp2 = add i64 %tmp, 1
+  %tmp3 = ashr i64 %tmp2, 32
+  ret void
+
+bb4:                                              ; preds = %bb13, %bb
+  %tmp5 = phi i64 [ 2, %bb ], [ %tmp14, %bb13 ]
+  %tmp6 = add i64 %tmp5, 4
+  %tmp7 = trunc i64 %tmp6 to i16
+  %tmp8 = urem i16 %tmp7, 3
+  %tmp9 = mul i16 %tmp8, 2
+  %tmp10 = icmp eq i16 %tmp9, 1
+  br i1 %tmp10, label %bb11, label %bb13
+
+bb11:                                             ; preds = %bb4
+  %tmp12 = udiv i16 1, %tmp7
+  unreachable
+
+bb13:                                             ; preds = %bb4
+  %tmp14 = add nuw nsw i64 %tmp5, 6
+  br i1 undef, label %bb1, label %bb4
+}
Index: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
+++ llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
@@ -3934,6 +3934,9 @@
 
   // Check each interesting stride.
   for (int64_t Factor : Factors) {
+    // Check that Factor can be represented by IntTy
+    if (!ConstantInt::isValueValidForType(IntTy, Factor))
+      continue;
     // Check that the multiplication doesn't overflow.
     if (Base.BaseOffset == std::numeric_limits<int64_t>::min() && Factor == -1)
       continue;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108772.369192.patch
Type: text/x-patch
Size: 1769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210827/0ad3b8fd/attachment.bin>