[PATCH] D108837: [SimplifyCFG] Ignore free instructions when computing cost for folding branch to common dest

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:3230
     // Ignore dbg intrinsics, and the terminator.
     if (isa<DbgInfoIntrinsic>(I) || isa<BranchInst>(I))
       continue;
----------------
lebedev.ri wrote:
> aeubanks wrote:
> > xbolva00 wrote:
> > > Skip also AssumeInst?
> > should be handled with the new code
> > and actually, same with DbgInfoIntrinsic, which I've updated
> Surely assumes aren't speculatable?
oh yes you're right
anyway, can be handled in a separate patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108837/new/

https://reviews.llvm.org/D108837