[PATCH] D108840: [WebAssembly] Fix FastISel of condition in different block (PR51651)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 27 13:27:44 PDT 2021


nikic added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp:433
-    return getRegForValue(NotV);
-  }
-
----------------
This code could principally have the same issue. However, it's also dead code, so I just dropped it entirely.

The reason it's dead is that V must have i1 type here (used either as a branch or select condition), while this checks that the type is i32.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108840/new/

https://reviews.llvm.org/D108840



More information about the llvm-commits mailing list