[PATCH] D108839: [DAGCombiner][RISCV] Don't use vector types in DAGCombiner::tryStoreMergeOfLoads if we need a rotate.

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added reviewers: frasercrmck, rogfer01, RKSimon, spatel.
Herald added subscribers: vkmr, ecnelises, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya.
craig.topper requested review of this revision.
Herald added a subscriber: MaskRay.
Herald added a project: LLVM.

The check for whether a rotate is possible occurs before the
memory legality checks for the integer type. So it's possible we
decide we can use a rotate, but then fail the legality checks. If
that happens we should not fall back to a vector type. This triggers
an assertion in the rotate handling when it finds a vector type
instead of an integer type.

In theory we could use a shufflevector in place of the rotate, but
right now I'd just like to fix the crash.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108839

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-store-merge-crash.ll


Index: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-store-merge-crash.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/rvv/fixed-vectors-store-merge-crash.ll
@@ -0,0 +1,31 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=riscv64 -mattr=+experimental-zbb,+experimental-v \
+; RUN:     -riscv-v-vector-bits-min=128 | FileCheck %s
+
+; This test loads to values and stores them in reversed order. This previously
+; asserted because part of DAGCombiner::tryStoreMerge thinks we can use an i64
+; rotate, but the loads aren't sufficiently aligned. So then it tried to use
+; a vector type, but that can't handle the swapped case.
+
+ at foo = global [2 x i32] zeroinitializer, align 4
+ at bar = global [2 x i32] zeroinitializer, align 4
+
+define void @baz() nounwind {
+; CHECK-LABEL: baz:
+; CHECK:       # %bb.0: # %entry
+; CHECK-NEXT:    lui a0, %hi(foo)
+; CHECK-NEXT:    addi a1, a0, %lo(foo)
+; CHECK-NEXT:    lw a1, 4(a1)
+; CHECK-NEXT:    lw a0, %lo(foo)(a0)
+; CHECK-NEXT:    lui a2, %hi(bar)
+; CHECK-NEXT:    sw a1, %lo(bar)(a2)
+; CHECK-NEXT:    addi a1, a2, %lo(bar)
+; CHECK-NEXT:    sw a0, 4(a1)
+; CHECK-NEXT:    ret
+entry:
+  %0 = load i32, i32* getelementptr inbounds ([2 x i32], [2 x i32]* @foo, i64 0, i64 1), align 4
+  store i32 %0, i32* getelementptr inbounds ([2 x i32], [2 x i32]* @bar, i64 0, i64 0), align 4
+  %1 = load i32, i32* getelementptr inbounds ([2 x i32], [2 x i32]* @foo, i64 0, i64 0), align 4
+  store i32 %1, i32* getelementptr inbounds ([2 x i32], [2 x i32]* @bar, i64 0, i64 1), align 4
+  ret void
+}
Index: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -17658,7 +17658,11 @@
 
       bool IsFastSt = false;
       bool IsFastLd = false;
-      if (TLI.isTypeLegal(StoreTy) &&
+      // Don't try vector types if we need a rotate. We may still fail the
+      // legality checks for the integer type, but we can't handle the rotate
+      // case with vectors.
+      // FIXME: We could use a shuffle in place of the rotate.
+      if (!NeedRotate && TLI.isTypeLegal(StoreTy) &&
           TLI.canMergeStoresTo(FirstStoreAS, StoreTy,
                                DAG.getMachineFunction()) &&
           TLI.allowsMemoryAccess(Context, DL, StoreTy,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108839.369172.patch
Type: text/x-patch
Size: 2480 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210827/04de398a/attachment.bin>