[PATCH] D104143: [IRSim][IROutliner] Canonicalizing commutative value numbering between similarity sections.

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM after fixing nits on comments.



================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:764
+  DenseSet<unsigned> UsedGVNs;
+  // Iterate over the mappings provided from this candidate to A.
+  for (std::pair<unsigned, DenseSet<unsigned>> &GVNMapping : ToSourceMapping) {
----------------
Can you change this comment to explain //why// you're iterating over the mappings?


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:771
+    unsigned ResultGVN;
+    // We need special handling if we have more than one potential value.
+    if (GVNMapping.second.size() > 1) {
----------------
Can you explain why?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104143/new/

https://reviews.llvm.org/D104143