[PATCH] D108835: [NVPTX] consider nvptx-nvidia-gpulibs triple to be compatible with other variants.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

FWIW, with OpenMP we now see 3 warnings:

  [ 90%] Building CXX object ...
  warning: linking module '/usr/local/cuda-11.0/nvvm/libdevice/libdevice.10.bc': Linking two modules of different data layouts: '/usr/local/cuda-11.0/nvvm/libdevice/libdevice.10.bc' is '' whereas '...' is 'e-i64:64-i128:128-v16:16-v32:32-n16:32:64'
   [-Wlinker-warnings]
  warning: linking module '/usr/local/cuda-11.0/nvvm/libdevice/libdevice.10.bc': Linking two modules of different target triples: '/usr/local/cuda-11.0/nvvm/libdevice/libdevice.10.bc' is 'nvptx64-nvidia-gpulibs' whereas '...' is 'nvptx64-nvidia-cuda'
   [-Wlinker-warnings]
  warning: linking module '/soft/llvm/main-20210824/lib/libomptarget-nvptx-sm_80.bc': Linking two modules of different target triples: '/soft/llvm/main-20210824/lib/libomptarget-nvptx-sm_80.bc' is 'nvptx64' whereas '...' is 'nvptx64-nvidia-cuda'
   [-Wlinker-warnings]

This patch should fix the middle one. The last one we can fix ourselves by always embedding canonical/full triples. The first one I am not sure about yet.

Long story short, I think this makes sense. LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108835/new/

https://reviews.llvm.org/D108835