[PATCH] D108298: [NPM] Print '-passes' compatible string for built pipeline.

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 27 11:34:01 PDT 2021


aeubanks added a comment.

could you add some tests?
but don't check the exact output of something like `-passes=default<O3>`, we don't need more golden files to update when we update the pipeline. is it possible to get the output of one RUN line and use it in the next? to check if the output of `-print-pipeline-passes -passes=default<O3>` works.

we still have no guarantee that the generated output will exactly match the original pipeline. I think it's important to mention that in the description and in the flag.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108298/new/

https://reviews.llvm.org/D108298



More information about the llvm-commits mailing list