[PATCH] D107861: [MC] Change ELFOSABI_NONE to ELFOSABI_GNU for STB_GNU_UNIQUE

[Fangrui Song via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG83dfa0d098f3: [MC] Change ELFOSABI_NONE to ELFOSABI_GNU for STB_GNU_UNIQUE (authored by MaskRay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107861/new/

https://reviews.llvm.org/D107861

Files:
  llvm/lib/MC/MCELFStreamer.cpp
  llvm/test/MC/ELF/gnu-type.s
  llvm/test/MC/ELF/gnu-unique.s


Index: llvm/test/MC/ELF/gnu-unique.s
===================================================================
--- /dev/null
+++ llvm/test/MC/ELF/gnu-unique.s
@@ -0,0 +1,13 @@
+# RUN: llvm-mc -triple=x86_64 %s | FileCheck %s --check-prefix=ASM
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %s | llvm-readelf -h -s - | FileCheck %s --check-prefix=OBJ
+
+# ASM: .type unique, at gnu_unique_object
+
+# OBJ: OS/ABI: UNIX - GNU
+# OBJ: Type   Bind   Vis     Ndx Name
+# OBJ: OBJECT UNIQUE DEFAULT [[#]] unique
+
+.data
+.globl unique
+.type unique, @gnu_unique_object
+unique:
Index: llvm/test/MC/ELF/gnu-type.s
===================================================================
--- llvm/test/MC/ELF/gnu-type.s
+++ llvm/test/MC/ELF/gnu-type.s
@@ -29,10 +29,3 @@
 
 	.type string_type, "function"
 // CHECK: .type string_type, at function
-
-	.type special gnu_unique_object
-// CHECK: .type special, at gnu_unique_object
-
-	.type comma_special, gnu_unique_object
-// CHECK: .type comma_special, at gnu_unique_object
-
Index: llvm/lib/MC/MCELFStreamer.cpp
===================================================================
--- llvm/lib/MC/MCELFStreamer.cpp
+++ llvm/lib/MC/MCELFStreamer.cpp
@@ -224,6 +224,7 @@
   case MCSA_ELF_TypeGnuUniqueObject:
     Symbol->setType(CombineSymbolTypes(Symbol->getType(), ELF::STT_OBJECT));
     Symbol->setBinding(ELF::STB_GNU_UNIQUE);
+    getAssembler().getWriter().markGnuAbi();
     break;
 
   case MCSA_Global:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107861.369113.patch
Type: text/x-patch
Size: 1433 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210827/0ce21094/attachment.bin>