[PATCH] D105466: [RuntimeDyld] Implemented relocation of TLS symbols in ELF

[Moritz Sichert via Phabricator via llvm-commits]

MoritzS added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:1861
       processSimpleRelocation(SectionID, Offset, RelType, Value);
+    } else if (RelType == ELF::R_X86_64_GOTTPOFF) {
+      // Use the approach from "x86-64 Linker Optimizations" from the TLS spec
----------------
lhames wrote:
> This function is pretty big already. Could the TLV code be split out into separate functions for readability?
That's a good idea. Maybe this will also make it easier to port this to JITLink in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105466/new/

https://reviews.llvm.org/D105466