[PATCH] D95747: Fix modules build for LLVMOrcShared

Fri Aug 27 03:20:58 PDT 2021

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Sorry for the very delayed review!

In D95747#2532432 <https://reviews.llvm.org/D95747#2532432>, @sgraenitz wrote:

> @lhames Does anything prevent us from having a dedicated JITTargetAddress in OrcShared?

No. I recently added an `ExecutorAddress` class to OrcShared that I would like to use to slowly replace JITTargetAddress (in both ORC and JITLink), but I think that it is a good idea to have a dedicated JITTargetAddress in OrcShared to simplify the library story in the short term.

> Am I remembering correctly, that JITSymbol is last dependency to ExecutionEngine? Maybe, now that release 12 branched we could think about planning a change like this?

I agree. I think we should wait until the current ExecutorProcessControl work settles down: that will allow us to remove a lot of existing code, which will make decoupling ORC from ExecutionEngine even easier. I think LLVM 14 or LLVM 15 is a reasonable timeframe for this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95747/new/

https://reviews.llvm.org/D95747