[PATCH] D108734: [InstCombine] Replace icmp invariant group operands with the invariant group's operands

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Seems fine to me with nits



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:5709-5711
+          I.getOperand(0)->getType()->getPointerAddressSpace())) {
+    return nullptr;
+  }
----------------



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:5714-5715
+  if (match(I.getOperand(0), m_Instruction(Op)) &&
+      match(I.getOperand(1), m_Zero())) {
+    if (Op->isLaunderOrStripInvariantGroup())
+      return ICmpInst::Create(Instruction::ICmp, I.getPredicate(),
----------------
Could flatten the if's


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:5719
+  }
+  return nullptr;
+}
----------------
Could do early-return, but not sure how better that would be here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108734/new/

https://reviews.llvm.org/D108734