[PATCH] D108769: [lld][Hexagon] Add check for missing predicated TLS reloc

[Brian Cain via Phabricator via llvm-commits]

bcain accepted this revision.
bcain added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/ELF/Arch/Hexagon.cpp:238
   error("unrecognized instruction for R_HEX_16_X relocation: 0x" +
         utohexstr(insn));
   return 0;
----------------
sidneym wrote:
> bcain wrote:
> > This error message is inaccurate, right?  In this case it's not that relocation mode.  If this error case applies to multiple relocations we should probably describe those here instead.
> > 
> > I'm not sure which ones apply but `R_HEX_{16_X,TPREL_16}` could work.  Are there lld idioms about the format of these error messages that we should conform to?
> It could be changed to 16_X relocation type.
`unrecognized instruction for 16_X relocation` -- like that?  If so, that makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108769/new/

https://reviews.llvm.org/D108769