[PATCH] D108158: AMDGPU: Invert AMDGPUAttributor

[Matt Arsenault via Phabricator via llvm-commits]

arsenm closed this revision.
arsenm added a comment.

088cc63640f4593a0af1fc81859853d5ee0d00ef <https://reviews.llvm.org/rG088cc63640f4593a0af1fc81859853d5ee0d00ef>



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:435
+    return getAssumed() != OrigAssumed ? ChangeStatus::CHANGED :
+                                         ChangeStatus::UNCHANGED;
   }
----------------
jdoerfert wrote:
> Nit: consider a lambda for this check, we probably should have a helper in the `AA` namespace so you can do `return AA::getChangeStatus(OrigAssumed, getAssumed());` It is really common by now.
A lamdba is way too heavy for this, especially since it's just to return a glorified bool


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108158/new/

https://reviews.llvm.org/D108158