[PATCH] D107861: [MC] Change ELFOSABI_NONE to ELFOSABI_GNU for STB_GNU_UNIQUE

Thu Aug 26 16:32:38 PDT 2021

MaskRay added a comment.

In D107861#2968300 <https://reviews.llvm.org/D107861#2968300>, @jrtc27 wrote:

> I'm concerned that this will turn ELFOSABI_FREEBSD objects into ELFOSABI_GNU ones, which can sometimes break things. This GNU extension is implemented by FreeBSD too so we shouldn't be forcing ELFOSABI_GNU, just avoiding ELFOSABI_NONE, and giving an error if you have a different ELFOSABI that doesn't support these things.

This is not an issue. `llvm-mc -triple=x86_64-freebsd` sets ELFOSABI_FREEBSD. This overrides the implicit ELFOSABI_GNU.

On FreeBSD, the default triple is set to *-freebsd.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107861/new/

https://reviews.llvm.org/D107861