[PATCH] D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType

[Chih-Ping Chen via Phabricator via llvm-commits]

cchen15 added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/dbg-distringtype-uint.ll:67
+
+attributes #0 = { mustprogress nofree norecurse nosync nounwind readnone uwtable willreturn "frame-pointer"="none" "intel-lang"="fortran" "min-legal-vector-width"="0" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" }
+attributes #1 = { nofree nounwind uwtable "frame-pointer"="none" "intel-lang"="fortran" "min-legal-vector-width"="0" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" }
----------------
aprantl wrote:
> Can you remove all attributes that are not strictly necessary (especially the ones in quotes)?
Excessive attributes eliminated. Thanks for the review, Adrian!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108559/new/

https://reviews.llvm.org/D108559