[PATCH] D108745: [asan] Fixed a runtime crash.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

In D108745#2967460 <https://reviews.llvm.org/D108745#2967460>, @kstoimenov wrote:

> So the test will compile to an executable, so it will have to be a cpp file with a main. Then it will run 'objdump --disassemble=__asan_check_load4_rn53' and check that the machine code is properly generated. Where would be a good place to put this kind of test? The llvm/test/CodeGen/X86 location doesn't seem to be a good place as it has only .ll files in it.

No. I am asking about extending tests of original patch.
Something must be different. Maybe one of obj files contains code with different reg then the rest and linker just picked not the one you are expected.
Maybe flags used to compile that object file was somehow special.

Would be nice to find-out why. I am not comfortable (as with the same place in the original patch as well) with having code which makes a difference, but invisible to tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108745/new/

https://reviews.llvm.org/D108745