[PATCH] D108328: [lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared libs

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 26 12:09:03 PDT 2021


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks like archive-fetch.s is unrelated. LG.

I do encourage that contributors try making tests a bit more orthogonal and reorganize tests whenever that makes sense.

`undef-in-shared-from-lazy.s` => how about `dso-undef-extract-lazy`?



================
Comment at: lld/test/ELF/undef-in-shared-from-lazy.s:35
+
+#--- archive
+.global foo
----------------
Use `.s` suffix


================
Comment at: lld/test/ELF/undef-in-shared-from-lazy.s:39
+
+#--- shlib
+.global foo
----------------
Use .s suffix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108328/new/

https://reviews.llvm.org/D108328



More information about the llvm-commits mailing list