[PATCH] D108137: [AArch64][Global ISel] Add sext/zext improvements
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 26 11:22:21 PDT 2021
aemerson added inline comments.
================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:4849
+ if (!mi_match(MI.getOperand(1).getReg(), MRI,
+ m_Copy(m_GExtractVectorElt(m_Reg(Src0), m_ICst(Lane)))))
+ return false;
----------------
Why are we trying to match a copy? These should have been combined away. If there are cases where they aren't, then we should probably manually match the pattern using a helper like `getOpcodeDef()` which can look through copies.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108137/new/
https://reviews.llvm.org/D108137
More information about the llvm-commits
mailing list