[PATCH] D108747: [llvm][ProfileData] Add a warning to indicate potentially corrupted data

[Xinliang David Li via llvm-commits]

Both Roland and Petr's suggestions are great.

On Thu, Aug 26, 2021 at 10:00 AM Petr Hosek via Phabricator <
reviews at reviews.llvm.org> wrote:

> phosek added a comment.
>
> Since these fields come from the binary and should be identical (profile
> runtime simply copies them into the raw profile),  a different approach
> would be to have a new subcommand in `llvm-profdata` to validate the
> profile against the binary to check if those fields are indeed the same,
> for example something like `llvm-profdata validate --object=<binary>
> <profile>.profraw` (alternatively it could also be just a flag, for example
> `llvm-profdata merge --validate=<binary> <profile>.profraw`).
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D108747/new/
>
> https://reviews.llvm.org/D108747
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210826/af3bd0e7/attachment.html>