[llvm] c4dc81e - [AArch64] provide strictfp attributes in test file

Simon Wallis via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 26 08:57:14 PDT 2021


Author: Simon Wallis
Date: 2021-08-26T16:56:43+01:00
New Revision: c4dc81eeabdb05f9226415c0196837485ed09d96

URL: https://github.com/llvm/llvm-project/commit/c4dc81eeabdb05f9226415c0196837485ed09d96
DIFF: https://github.com/llvm/llvm-project/commit/c4dc81eeabdb05f9226415c0196837485ed09d96.diff

LOG: [AArch64] provide strictfp attributes in test file

A post-commit review comment on  https://reviews.llvm.org/D107452 pointed out that
https://llvm.org/docs/LangRef.html
says:
"In a function that uses the constrained intrinsics the strictfp attribute is required on all function calls."

Although there are several files across several test directories which don't follow this guidance, it is straightforward to provide this attribute.

Reviewed By: kpn

Differential Revision: https://reviews.llvm.org/D107567

Added: 
    

Modified: 
    llvm/test/CodeGen/AArch64/fptosi-strictfp.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/AArch64/fptosi-strictfp.ll b/llvm/test/CodeGen/AArch64/fptosi-strictfp.ll
index 240775853285..62c5d4fcc9b1 100644
--- a/llvm/test/CodeGen/AArch64/fptosi-strictfp.ll
+++ b/llvm/test/CodeGen/AArch64/fptosi-strictfp.ll
@@ -2,22 +2,24 @@
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
 target triple = "aarch64-arm-none-eabi"
 
-define i128 @test_fixtfti(fp128 %ld) {
+define i128 @test_fixtfti(fp128 %ld) #0 {
 ; CHECK-LABEL: test_fixtfti:
 ; CHECK: bl	__fixtfti
 entry:
-  %conv = call i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128 %ld, metadata !"fpexcept.strict")
+  %conv = call i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128 %ld, metadata !"fpexcept.strict") #0
   ret i128 %conv
 }
 
 declare i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128, metadata)
 
-define i128 @test_fixtftu(fp128 %ld) {
+define i128 @test_fixtftu(fp128 %ld) #0 {
 ; CHECK-LABEL: test_fixtftu:
 ; CHECK: bl	__fixunstfti
 entry:
-  %conv = call i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128 %ld, metadata !"fpexcept.strict")
+  %conv = call i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128 %ld, metadata !"fpexcept.strict") #0
   ret i128 %conv
 }
 
 declare i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128, metadata)
+
+attributes #0 = { strictfp }


        


More information about the llvm-commits mailing list