[PATCH] D108298: [NPM] Print '-passes' compatible string for built pipeline.

[Markus Lavin via Phabricator via llvm-commits]

markus marked 2 inline comments as done.
markus added inline comments.


================
Comment at: llvm/include/llvm/IR/PassManager.h:387
+    auto ClassName = name();
+    auto PassName = PIC.getPassNameForClassName(ClassName);
+    if (!PassName.empty()) {
----------------
bjope wrote:
> IMHO the getPassNameForClassName function is pretty trivial. Maybe you should just pass around a reference to the ClassToPassName StringMap instead. That will show that we do not really depend on or use the PassInstrumentationCallbacks class. We are only interested in the StringMap (and in the future that could be implemented somewhere else and not in the PassInstrumentationCallbacks class). Or what do you think about that?
Done or at least did something to the same effect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108298/new/

https://reviews.llvm.org/D108298