[PATCH] D108724: [LoopPredication] Preserve MemorySSA

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 26 06:52:45 PDT 2021


anna added a comment.

In D108724#2966683 <https://reviews.llvm.org/D108724#2966683>, @nikic wrote:

> LGTM. Doesn't look like this pass is doing anything exciting with memory or control flow, so this should be sufficient...

Nothing w.r.t. memory. And control flow - we "widen" an existing check across iterations of a loop. We don't have any `DT` updates, so I reached the conclusion that there's no MSSA updates needed either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108724/new/

https://reviews.llvm.org/D108724



More information about the llvm-commits mailing list