[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0-rc1 spec

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:134
          "maximum!");
+  assert(RVVVectorBitsMin >= ZvlLen &&
+         "Minimum V extension vector length should be at least the length "
----------------
eopXD wrote:
> craig.topper wrote:
> > HsiangKai wrote:
> > > Should it be `RVVVectorBitsMin < ZvlLen`?
> > > 
> > > I suggest to return 0 and print a warning message for users.
> > This isn't a good place to print warnings. It would just be a random message printed to stderr without going through any of clang's diagnostic infrastructure.
> I think moving the check to `initializeSubtargetDependencies` and use `report_fatal_error` will be a more appropriate approach?
I think that causes clang to generate a crash report and telling the user to file a bug.

Forgot to mention, all this code is also being modified by D107290


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108694/new/

https://reviews.llvm.org/D108694