[PATCH] D108697: [Coroutines] [libcxx] Move coroutine components out from std::experimental namespace

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 25 23:28:38 PDT 2021


ChuanqiXu added a comment.

In D108697#2966516 <https://reviews.llvm.org/D108697#2966516>, @lxfind wrote:

>> In D108696 <https://reviews.llvm.org/D108696>, the clang would lookup in std and std::experimental namespace. And this patch would only be checked in after D108696 <https://reviews.llvm.org/D108696> get checked in. So I think it wouldn't affect users much.
>
> Well, but if user code has "#include <experimental/coroutine>", would it still compile?

Yes, it wouldn't compile. So in this revision, I remained the <experimental/coroutine> and add a warning directive to notice the user to include <coroutine>.
Now the user codes should be able to compile all the way after the user update either clang or libcxx. The only exception is that the user uses `-Werror`. It would the codes couldn't compile after updating. But I think we can't do nothing better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108697/new/

https://reviews.llvm.org/D108697



More information about the llvm-commits mailing list