[PATCH] D108689: [Linker] Support weak symbols in nodeduplicate COMDAT group

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

This is a workaround instead of a proper fix. `comdat nodeduplicate` does not perform deduplication. `LinkFromSrc` is for deduplication, so not suitable.
All the members should be tested.
For InstrProfiling.cpp, I agree that the deduplication semantic is a sufficient workaround.



================
Comment at: llvm/test/Linker/comdat4.ll:2
 ; RUN: not llvm-link %s %p/Inputs/comdat3.ll -S -o - 2>&1 | FileCheck %s
+; RUN: llvm-link %s %p/Inputs/comdat6.ll -S -o - 2>&1
+; RUN: llvm-link %p/Inputs/comdat6.ll %s -S -o - 2>&1
----------------
Use `split-file` to avoid an one-off `Inputs/` file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108689/new/

https://reviews.llvm.org/D108689