[PATCH] D108635: [CGP] Fix the crash for combining address mode when having cyclic dependency

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 25 20:04:37 PDT 2021


skatkov accepted this revision.
skatkov added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:3721
       for (auto &P : PHI->getParent()->phis()) {
-        if (&P == PHI)
+        if (PhiNodesToMatch.count(&P))
           continue;
----------------
Please add a comment, like:
Skip new phi nodes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108635/new/

https://reviews.llvm.org/D108635



More information about the llvm-commits mailing list