[PATCH] D108705: [AArch64][SVE] Add API for conversion between SVE predicate pattern and element count. NFC

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 25 19:12:19 PDT 2021


junparser added inline comments.


================
Comment at: llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h:470-471
+  case AArch64SVEPredPattern::vl8:
+    MinNumElts = Pattern;
+    break;
+  case AArch64SVEPredPattern::vl16:
----------------
paulwalker-arm wrote:
> Is there an LLVM coding style policy here? For example is setting `MinNumElts` and breaking preferred over just using return.
I checked https://llvm.org/docs/CodingStandards.html, There is no rules for switch cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108705/new/

https://reviews.llvm.org/D108705



More information about the llvm-commits mailing list