[llvm] 1bdeafe - [gn build] Unbreak non-clang host builds
Arthur Eubanks via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 25 16:15:58 PDT 2021
Author: Arthur Eubanks
Date: 2021-08-25T16:14:45-07:00
New Revision: 1bdeafeaf435c86596e28e737979c110666ef387
URL: https://github.com/llvm/llvm-project/commit/1bdeafeaf435c86596e28e737979c110666ef387
DIFF: https://github.com/llvm/llvm-project/commit/1bdeafeaf435c86596e28e737979c110666ef387.diff
LOG: [gn build] Unbreak non-clang host builds
eecd5d0a broke non-clang host builds.
Some crt code is not always built with the just-built clang.
0da172b checked if the compiler is clang, not assert that the compiler
is clang.
Added:
Modified:
llvm/utils/gn/build/BUILD.gn
Removed:
################################################################################
diff --git a/llvm/utils/gn/build/BUILD.gn b/llvm/utils/gn/build/BUILD.gn
index b0f02cf6a937d..31a5741e4524b 100644
--- a/llvm/utils/gn/build/BUILD.gn
+++ b/llvm/utils/gn/build/BUILD.gn
@@ -407,12 +407,13 @@ config("crt_code") {
"-gline-tables-only",
"-fvisibility=hidden",
]
- assert(is_clang, "CRT code is always built with just-built clang")
- cflags += [
- "-Werror=thread-safety",
- "-Werror=thread-safety-reference",
- "-Werror=thread-safety-beta",
- ]
+ if (is_clang) {
+ cflags += [
+ "-Werror=thread-safety",
+ "-Werror=thread-safety-reference",
+ "-Werror=thread-safety-beta",
+ ]
+ }
}
config("warn_covered_switch_default") {
More information about the llvm-commits
mailing list