[PATCH] D108729: [WebAssembly] Use entry block only for initializations in EmSjLj

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 25 15:41:58 PDT 2021


aheejin added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/lower-em-sjlj-alias.ll:19-20
   ; CHECK: call i8* @malloc
-  ; CHECK: call i32* @saveSetjmp
-  ; CHECK: call i32 @getTempRet0
   %retval = alloca i32, align 4
----------------
tlively wrote:
> Why remove these entirely rather than check for them in the new output?
Not sure why I added them in the first place. All this test checks is that `malloc` is not transformed into an invoke, so I thought adding `entry.split:` `call i32* saveSetjmp`, ... would be unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108729/new/

https://reviews.llvm.org/D108729



More information about the llvm-commits mailing list