[PATCH] D106991: [CodeExtractor] Allowing for caller to access final inputs and outputs.

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.

LGTM with one more nit



================
Comment at: llvm/include/llvm/Transforms/Utils/CodeExtractor.h:147
+    /// hoisting, and extracting lifetime values and assumes.
+    /// \param Inputs [out] - SetVector of the values marked as inputs to the
+    /// newly outlined function.
----------------
maybe just say "filled with input values to the outlined function"?

even though this is a typedef of SetVector, it's a little confusing when looking at this locally.

(similar nit with `Outputs`)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106991/new/

https://reviews.llvm.org/D106991