[PATCH] D108719: [asan] Removed unused cast in the IR by moving AddrLong init after optimized callback section.

[Kirill Stoimenov via Phabricator via llvm-commits]

kstoimenov added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1780
 
+  if (UseCalls && ClOptimizeCallbacks) {
+    const ASanAccessInfo AccessInfo(IsWrite, CompileKernel, AccessSizeIndex);
----------------
vitalybuka wrote:
> ClOptimizeCallbacks does not exist in the HEAD,
> I guess some parent patches are missing
D'oh! I have to push the flag patch first of course. 


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1781
+  if (UseCalls && ClOptimizeCallbacks) {
+    const ASanAccessInfo AccessInfo(IsWrite, CompileKernel, AccessSizeIndex);
+    Module *M = IRB.GetInsertBlock()->getParent()->getParent();
----------------
vitalybuka wrote:
> no tests needs to be updated?
I stated working on tests in the parent patch an this is how I found this inefficiency. I will them accordingly. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108719/new/

https://reviews.llvm.org/D108719