[PATCH] D106440: [IROutliner] Change Prioritization of Outlining to honor cost model

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1382
+      return true;
+    return !this->InstructionClassifier.visit(ID.Inst);
+  });
----------------
AndrewLitteken wrote:
> paquette wrote:
> > Do you need `this` here?
> > 
> > also you can probably just write
> > 
> > ```
> > return (std::next(...)->Inst != ID.Inst...) || !InstructionClassifier.visit(ID.Inst);
> > ```
> I would rather keep it like this, the next few patches build on this and becomes more complex when the instruction could be a branch, and it isn't so easy to make it a one liner.
SGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106440/new/

https://reviews.llvm.org/D106440