[PATCH] D104142: [IROutliner] Ensure instructions at end of candidate are excluded

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:139
+
+  // We check if the current instruction following the last instruction in the
+  // region is the same as the recorded instruction following the last
----------------
run-on sentence?


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:147
+  Instruction *StartInst = (*Candidate->begin()).Inst;
+  assert(StartInst && EndInst && "Expected a start instruction?");
   StartBB = StartInst->getParent();
----------------
message should reflect the check


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1700
+
+      // There's a chance that when the region is split, extra instructions are
+      // added changing the possibility of outlining, and it is no longer viable
----------------
run-on sentence?


================
Comment at: llvm/test/Transforms/IROutliner/outlining-bitcasts.ll:53
+; endpoint does not match the new endpoint, we cannot extract and outline the
+; second bitcast and set of ads.  Outlining only occurs in this case due to
+; the lack of a cost model, as denoted by the debug command line argument.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104142/new/

https://reviews.llvm.org/D104142