[PATCH] D108723: [M68k][NFC] Fix enum references in the asm parser

Ricky Taylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 25 13:01:45 PDT 2021


ricky26 added a comment.

In D108723#2965766 <https://reviews.llvm.org/D108723#2965766>, @glaubitz wrote:

> As suggested here [1] by @jrtc27, I think the better solution is to rename the enum `Kind` to `KindTy`.
>
>> [1] https://github.com/rust-lang/rust/pull/88321#discussion_r696043053
>
> Edit: Rename because that would match the naming scheme also used by the RISCV AsmParser.

Ah, I missed that comment. I agree, I'll swap it over. Thanks for adding in @jrtc27.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108723/new/

https://reviews.llvm.org/D108723



More information about the llvm-commits mailing list