[PATCH] D108679: Restrict ARM IT Blocks on Windows
Daniel Paoliello via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 25 10:17:21 PDT 2021
dpaoliello added a comment.
In D108679#2964617 <https://reviews.llvm.org/D108679#2964617>, @kristof.beyls wrote:
> The performance deprecation of certain forms of IT blocks has been reverted.
> The performance deprecation notes are being removed from the Arm ARM.
> I am expecting that in the near future, code generation for Arm will be adapted to not enable -mrestrict-it by default at all, following what was already done in gcc at https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg00134.html.
>
> As such, I'm not sure if this patch is a good thing to implement.
> Maybe the guidelines in Microsoft's document you point to (https://docs.microsoft.com/en-us/cpp/build/overview-of-arm-abi-conventions?view=msvc-160#it-instructions) should be adapted to take into account the above described changes to the ArmARM?
@kristof.beyls Can you please point me to any official documentation or announcement from ARM about this (I've tried looking myself but couldn't see anything)?
I'd be happy to abandon this change and get the Microsoft docs updated if these instructions are no longer deprecated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108679/new/
https://reviews.llvm.org/D108679
More information about the llvm-commits
mailing list