[PATCH] D108677: [CSSPGO] Add switch for sample loader to honor global pre-inliner decision from llvm-profgen

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

Can you add a test ?



================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:794
          "Cannot have both context-sensitive and regular profile");
-  assert(ProfileIsCS == (CSProfileCount > 0) &&
+  assert((!CSProfileCount || ProfileIsCS == (CSProfileCount > 0)) &&
          "Section flag should be consistent with actual profile");
----------------
Nit: `assert((!CSProfileCount || ProfileIsCS ) && ...` ? 


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1269
+  // stores the decision in profile, and also adjust/merge context profile
+  // aiming at better context-sensitive post-inline profile quality, assming
+  // all inline decision estimates are going to be honored by compiler. Here
----------------
typo; assming -> assuming


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108677/new/

https://reviews.llvm.org/D108677