[PATCH] D108703: [SLP]No need to schedule/check parent for extract{element/value} instruction.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 25 08:49:48 PDT 2021
RKSimon added a comment.
couple of minors
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:209
+
+static bool isVectorLikeInstWithConstOps(Value *V) {
+ if (!isa<InsertElementInst, ExtractElementInst, ExtractValueInst, UndefValue>(
----------------
Add description comment
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:211
+ if (!isa<InsertElementInst, ExtractElementInst, ExtractValueInst, UndefValue>(
+ V))
+ return false;
----------------
clang-format has made this pretty messy - maybe split it up?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108703/new/
https://reviews.llvm.org/D108703
More information about the llvm-commits
mailing list