[PATCH] D107473: [LLVM][LTO][NFC] Resolve FIXME in ThinLTOCodeGenerator.cpp
Alf via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 25 08:42:37 PDT 2021
gAlfonso-bit added a comment.
In D107473#2934894 <https://reviews.llvm.org/D107473#2934894>, @steven_wu wrote:
> Can you unify the duplicated code or just put the FIXME back saying need to fix the duplicated code in the future?
>
> Does the original code break any linter? Or it is just an attempt to rewrite the code using switch?
Should I just have the logic in a function? If I do, should I assume macOS is the target and cpu is empty or should I add those checks in the function?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107473/new/
https://reviews.llvm.org/D107473
More information about the llvm-commits
mailing list