[PATCH] D108627: [DebugInfo][InstrRef] Avoid a debug-info-affects-codegen scenarios in stack slot colouring

Wed Aug 25 04:20:09 PDT 2021

djtodoro accepted this revision.
djtodoro added a comment.

In D108627#2964736 <https://reviews.llvm.org/D108627#2964736>, @jmorse wrote:

> In D108627#2964729 <https://reviews.llvm.org/D108627#2964729>, @djtodoro wrote:
>
>> should we indicate that llvm/test/DebugInfo/MIR/InstrRef/* may depend on `sed` (in the lit config script)?
>
> IMO no -- there are various other test directories (test/CodeGen/X86) for example that use sed and don't appear to declare or specify this anywhere, and I'm not sure how we would do that anyway. I think this is a known assumption of the tests; I haven't seen it written down anywhere though.
>
> (Using perl on the RUN line would probably be too far!(

OK, lgtm.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108627/new/

https://reviews.llvm.org/D108627