[PATCH] D108627: [DebugInfo][InstrRef] Avoid a debug-info-affects-codegen scenarios in stack slot colouring
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 25 04:07:33 PDT 2021
djtodoro added a comment.
In D108627#2964725 <https://reviews.llvm.org/D108627#2964725>, @jmorse wrote:
> In D108627#2964710 <https://reviews.llvm.org/D108627#2964710>, @Orlando wrote:
>
>> I was worried about `sed` not being cross platform friendly but it appears that existing tests use it too. Out of curiosity, do you know what happens when this is run on Windows? LGTM either way.
>
> I believe Windows is expected to have the gnu command line tools available on the PATH. It gets really hard to write expressive tests otherwise.
should we indicate that llvm/test/DebugInfo/MIR/InstrRef/* may depend on `sed` (in the lit config script)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108627/new/
https://reviews.llvm.org/D108627
More information about the llvm-commits
mailing list