[PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on most platforms

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

With the proper checks modified, I guess this could be fine, after the libc++ handling in clang has been fixed/generalized for other ELF drivers.



================
Comment at: llvm/CMakeLists.txt:411
 option(LLVM_ENABLE_MODULES "Compile with C++ modules enabled." OFF)
-if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
+if(WIN32 OR ${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
   option(LLVM_ENABLE_MODULE_DEBUGGING "Compile with -gmodules." ON)
----------------
It looks to me like you modified the wrong condition


================
Comment at: llvm/CMakeLists.txt:675
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin")
+  set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default OFF)
+else()
----------------
... as this one still only checks for darwin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107799/new/

https://reviews.llvm.org/D107799