[PATCH] D108433: [CSSPGO] split context string - compiler changes

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 22:02:20 PDT 2021


wlei added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:573
+  bool operator>(const SampleContext &That) const {
+    return (*this != That) && !(*this < That);
+  }
----------------
is this more heavy operator than direct implementation of `>`(like `<`).

say if two contexts are very long and only the last frame is different.

it will take 2 * n for (*this != That) plus  !(*this < That), rather than n.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108433/new/

https://reviews.llvm.org/D108433



More information about the llvm-commits mailing list