[PATCH] D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions.
Vyacheslav Zakharin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 24 16:17:45 PDT 2021
vzakhari added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:475
+
+ for (Instruction *I : DebugInsts)
+ I->eraseFromParent();
----------------
Since `DebugInsts` does not get reset for each basic block, we may try to erase instructions that have already been erased. This triggers on my change to preserve the topological order for the return blocks created by `CodeExtractor`. @AndrewLitteken, do you mind if I move the declaration of `DebugInsts` into the `CurrBB` loop body as a part of my change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87302/new/
https://reviews.llvm.org/D87302
More information about the llvm-commits
mailing list